Some aspects of the code review process may vary from team-to-team so I’ve excluded them from my main article. Some finer details are included here.

• 💬 Comments with no explicit approval means the review is in progress. Only approved pull requests can be merged

  1️⃣ A few notes on the Github review states:

  • ⛔️ A “Changes Requested” response means that all feedback must be addressed and then another review will be needed

• ✅ An “Approved” response means the pull request can be merged by its author. Reviewers can leave feedback and even request changes while still responding with an approval.

  • 🤝 This means they trust the author to implement the suggestions and merge at their discretion to avoid another review cycle.
  • ⚠️ Trust is earned. Don’t abuse this privilege by flagrantly ignoring suggestions with no explanation.
  • 🔁 Don’t hesitate to request another review if you think it would be helpful

2️⃣ The Github free tier doesn’t allow for reviewers to be added automatically. Be sure to add me and any other teammates you’d like a review from as an assignee for each pull request.

3️⃣ Authors merge their own pull requests

4️⃣ This guide may be helpful for resolving pull request feedback that requires rewriting history, such as rewording commit messages:

Beginner’s Guide to Interactive Rebasing | HackerNoon